[haiku-commits] Re: r40457 - haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn

  • From: Stephan Aßmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 12 Feb 2011 10:58:10 +0100

On 12.02.2011 01:18, kallisti5@xxxxxxxxxxx wrote:
Author: kallisti5
Date: 2011-02-12 01:18:44 +0100 (Sat, 12 Feb 2011)
New Revision: 40457
Changeset: http://dev.haiku-os.org/changeset/40457

Added:
    haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/SettingsIfView.cpp
    haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/SettingsIfView.h
Modified:
    haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/Jamfile
    haiku/trunk/src/tests/kits/net/preflet/InterfacesAddOn/SettingsWindow.cpp
Log:
added BView class to handle drawing IPv4/IPv6 interface configuration options

If that is what is does then "InterfaceConfigurationView" would have been a much better name, or simply "ConfigurationView". "SettingsIfView" is a horrible name. :-) Naming should be done with someone in mind who looks at the code for the first time and tries to find the file that most likely implements something he would like to mess with. This could be yourself in a couple of month of not looking at the code. ;-)

Best regards,
-Stephan

Other related posts: