[haiku-commits] Re: r40322 - haiku/trunk/src/tests/kits/net/preflet/ServicesAddOn
- From: Ryan Leavengood <leavengood@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 30 Jan 2011 12:39:53 -0500
On Sun, Jan 30, 2011 at 12:26 PM, Alexander von Gluck
<kallisti5@xxxxxxxxxxx> wrote:
>
> Here is my confusion, every header I look at is different. Here is the
> style guideline, one of your headers, and one of my headers compared...
>
> http://i53.tinypic.com/5o9utj.png
Not all existing code, no matter who wrote it, is guaranteed to follow
the coding guidelines. So it isn't really an excuse to point to
someone else's code which doesn't follow the guidelines.
Things I can see in your header that need fixing are the addition of a
header guard, two spaces between the include and the class
declaration, not indenting public and protected, moving the protected
section below public and indenting more to the guidelines (a tab and
then the place were virtual and other method modifers would be, then a
tab or more and the return type, then several tabs and the method name
to line all those up.)
> Thoughts? I *do* really want to make sure my header style is correct
> and consistent with the projects... I just can't find a good guide on
> it.
The coding guidelines should always have preference. As long as you
code to them no one can complain. And if someone does complain then
clearly the guidelines need an addition.
And try not to feel persecuted: most of us commit style violations
occasionally and you'll get the hang of it soon.
--
Regards,
Ryan
Other related posts:
