[haiku-commits] Re: r40312 - in haiku/trunk/src/tests/kits/net/preflet: . InterfacesAddOn

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 29 Jan 2011 15:56:57 +0100

kallisti5@xxxxxxxxxxx wrote:
> +     rgb_color black= { 0,0,0,255 };

Spaces after ','.

> +        if (IsSelected()) {
> +            owner->SetHighColor(tint_color(owner->ViewColor() , 
> B_HIGHLIGHT_BACKGROUND_TINT));

80 character line limit.

> +        } else {
> +            owner->SetHighColor(owner->LowColor());
> +             }

No superfluous {}.

> +     BPoint v4addrPt = BPoint(32+12, fSecondlineOffset);
> +     BPoint v6addrPt = BPoint(32+12, fThirdlineOffset);

And again :-)

> -     if (fSettings->IsDisabled())
> +     if ( fSettings->IsDisabled() )

Here you replaced the former correct parenthesis spacing with a wrong 
one...

> -             if (fSettings->AutoConfigure())
> +             if ( fSettings->AutoConfigure() )

And here again.
Looks like you should practice more ;-)

Bye,
   Axel.


Other related posts: