[haiku-commits] Re: r40311 - in haiku/trunk/src/tests/kits/net/preflet: . InterfacesAddOn
- From: Alexander von Gluck <kallisti5@xxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 28 Jan 2011 16:55:25 -0600
On Fri, 2011-01-28 at 23:26 +0100, Axel Dörfler wrote:
> Stephan Aßmus <superstippi@xxxxxx> wrote:
> > > + BPoint namePt = BPoint(32+12, fFirstlineOffset);
>
> Why not directly use the constructor like this:
> BPoint namePt(32+12, fFirstlineOffset);
>
> If a shorter solution is more readable than a longer solution, always
> prefer the shorter version :-)
Good catch. It's easy to leave something weird when refactoring
existing code.
> > > - menu->AddItem(new BMenuItem(B_TRANSLATE("Delete"),
> > > - new BMessage(DELETE_PROFILE_MSG)));
> > I am guessing this option should eventually allow to delete the
> > currently selected/active profile. At least it makes sense to me. :-)
>
> I wondered about that, too, but hoped he knew what he did.
I do. The profile management window will have quite a few actions and
will most probably have it's own BMessage catcher. To avoid clutter,
moving the delete option to the profile management window makes sense.
> But while we're at it, what is that "prevent changes" check box for?.
> It's completely unclear to me, so it should either be removed, or get a
> better label IMO.
Keep in mind, I didn't originally write this preference applet
version :D
+1 on removing the prevent changes check box.
I think there is a lot that needs to be changed in this test preference
applet. Network changes need to happen in real time through the applet
and be saved to a network profile that will be read on startup. (that
way you have instant gratification, and you have the selected profile
set to load on boot)
--
Thanks!
-Alexander von Gluck IV
GPG/C32E7686
Other related posts:
