[haiku-commits] Re: r40109 - haiku/trunk/src/add-ons/screen_savers/butterfly

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 04 Jan 2011 19:03:35 +0100

On 2011-01-04 at 18:45:53 [+0100], Ryan Leavengood <leavengood@xxxxxxxxx> 
> On 1/4/11, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> > I have serious trouble seeing the purpose of this computation (why not
> > simply 1.f / 6?) or the comment for that matter.
> Please keep in mind I was just adding someone else's code and decided
> to not do major changes or refactorings since it seemed to work as is.
> And this is just grunt work which I decided to do to help Scott in the
> GCI.

And that's much appreciated. Nevertheless, the deal is that the committer 
is responsible for the code he commits (with the exception of imported 
third-party code we just make use of). So either one makes sure all issues 
are addressed before committing (e.g. by reviewing and asking the patch 
creator to fix them) or one has to live with the feedback. :-)

CU, Ingo

Other related posts: