[haiku-commits] Re: r40078 - haiku/trunk/src/system/boot/platform/bios_ia32

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 03 Jan 2011 02:03:27 +0100

On 2011-01-03 at 00:34:45 [+0100], Clemens Zeidler 
<clemens.zeidler@xxxxxxxxxxxxxx> wrote:
> Am 03.01.2011, 12:14 Uhr, schrieb <ingo_weinhold@xxxxxx>:
> 
> > Author: bonefish
> > Date: 2011-01-03 00:14:10 +0100 (Mon, 03 Jan 2011)
> > New Revision: 40078
> > Changeset: http://dev.haiku-os.org/changeset/40078
> >
> > Modified:
> >    haiku/trunk/src/system/boot/platform/bios_ia32/video.cpp
> > Log:
> > Fixed suspicious implicit sign extension computing the frame buffer size
> > (CIDs 8056, 8057, 8058).
> 
> Seems to fix #6601 :-)

Great! That probably means that Coverity's analysis was not quite correct 
as the sign extension issue would only be triggered with frame buffer sizes 
>= 2 GB, but I thought anyway that the result of (uint16 * uint16) was 
truncated to uint16, which would pretty much always result in an overflow.

CU, Ingo

Other related posts: