"Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx> wrote: > Stephan Assmus <superstippi@xxxxxx> wrote: > > Hope it's ok, since this was applying a patch, I thought it could > > be > > a > > good idea to simply do a commit instead of pointing out the coding > > style > > violations via email which seems a bit much overhead sometimes. If > > that's not considered good style, please shout! :-) > I would prefer to solve those issues before applying a patch. You can > still send the author a diff between his and your version if you like > to keep it simple. I wouldn't mind if we had a pre commit hook that > rejects commits with style violations in most directories. Sorry, I misread that mail; I thought you applied the patch as well. In this case, I think it's perfectly fine to save some time :-) Bye, Axel.