[haiku-commits] r39986 - haiku/trunk/src/servers/app/drawing/remote

  • From: mmlr@xxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 28 Dec 2010 17:52:29 +0100 (CET)

Author: mmlr
Date: 2010-12-28 17:52:29 +0100 (Tue, 28 Dec 2010)
New Revision: 39986
Changeset: http://dev.haiku-os.org/changeset/39986

Modified:
   haiku/trunk/src/servers/app/drawing/remote/RemoteHWInterface.cpp
Log:
CID 7961: Use snprintf with proper sizes to make sure nothing overflows.


Modified: haiku/trunk/src/servers/app/drawing/remote/RemoteHWInterface.cpp
===================================================================
--- haiku/trunk/src/servers/app/drawing/remote/RemoteHWInterface.cpp    
2010-12-28 16:44:24 UTC (rev 39985)
+++ haiku/trunk/src/servers/app/drawing/remote/RemoteHWInterface.cpp    
2010-12-28 16:52:29 UTC (rev 39986)
@@ -391,9 +391,9 @@
        info->version = fProtocolVersion;
        info->dac_speed = fConnectionSpeed;
        info->memory = 33554432; // 32MB
-       sprintf(info->name, "Haiku, Inc. RemoteHWInterface");
-       sprintf(info->chipset, "Haiku, Inc. Chipset");
-       sprintf(info->serial_no, fTarget);
+       snprintf(info->name, sizeof(info->name), "Haiku, Inc. 
RemoteHWInterface");
+       snprintf(info->chipset, sizeof(info->chipset), "Haiku, Inc. Chipset");
+       snprintf(info->serial_no, sizeof(info->serial_no), fTarget);
 
        ReadUnlock();
        return B_OK;


Other related posts:

  • » [haiku-commits] r39986 - haiku/trunk/src/servers/app/drawing/remote - mmlr