[haiku-commits] r39956 - haiku/trunk/src/add-ons/kernel/file_systems/udf

  • From: mmlr@xxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 27 Dec 2010 00:22:43 +0100 (CET)

Author: mmlr
Date: 2010-12-27 00:22:43 +0100 (Mon, 27 Dec 2010)
New Revision: 39956
Changeset: http://dev.haiku-os.org/changeset/39956

Modified:
   haiku/trunk/src/add-ons/kernel/file_systems/udf/kernel_interface.cpp
Log:
CID 2196: The sanity check did check the pointer size instead of the type size.


Modified: haiku/trunk/src/add-ons/kernel/file_systems/udf/kernel_interface.cpp
===================================================================
--- haiku/trunk/src/add-ons/kernel/file_systems/udf/kernel_interface.cpp        
2010-12-26 23:16:04 UTC (rev 39955)
+++ haiku/trunk/src/add-ons/kernel/file_systems/udf/kernel_interface.cpp        
2010-12-26 23:22:43 UTC (rev 39956)
@@ -434,8 +434,10 @@
        TRACE(("udf_read_dir: _volume = %p, vnode = %p, bufferSize = %ld\n",
                _volume, vnode, bufferSize));
 
-       if (!_volume || !vnode || !cookie || !_num || bufferSize < 
sizeof(dirent))
+       if (!_volume || !vnode || !cookie || !_num
+                       || bufferSize < sizeof(struct dirent)) {
                return B_BAD_VALUE;
+       }
 
        Volume *volume = (Volume *)_volume->private_volume;
        Icb *dir = (Icb *)vnode->private_node;


Other related posts:

  • » [haiku-commits] r39956 - haiku/trunk/src/add-ons/kernel/file_systems/udf - mmlr