[haiku-commits] Re: r39903 - haiku/trunk/src/preferences/notifications

  • From: Jérôme Duval <korli@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 21 Dec 2010 20:49:36 +0100

2010/12/21 Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>:
> Stephan Aßmus<superstippi@xxxxxx> wrote:
>> Without having looked at the implementation of RemoveItemAt(), I am
>> almost sure that it will perform those exact same checks. One would need
>> to make sure the method does not just return the icon, which would then
>> be leaked. I don't remember if a BObjectList owns the items by default,
>> and the default constructor is used according to this patch.
> BObjectList does not own the items by default. And removing items manually 
> should also not delete them.
> Even nicer would be (also only works correctly if the list owns its items):
> fIcons.MakeEmpty();

Thanks for the review: Patch committed in r39915.


Other related posts: