[haiku-commits] Re: r39896 - haiku/trunk/src/servers/notification
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 20 Dec 2010 22:14:31 +0100
On 2010-12-20 at 21:27:59 [+0100], Stephan Aßmus <superstippi@xxxxxx> wrote:
> Am 20.12.2010 18:31, schrieb philippe.houdoin@xxxxxxxxx:
> > Modified: haiku/trunk/src/servers/notification/NotificationView.cpp
> > ===================================================================
> > --- haiku/trunk/src/servers/notification/NotificationView.cpp
> > 2010-12-20 16:25:38 UTC (rev 39895)
> > +++ haiku/trunk/src/servers/notification/NotificationView.cpp
> > 2010-12-20 17:31:27 UTC (rev 39896)
> > @@ -326,15 +326,14 @@
> > iconRect.right = ix + iconSize;
> > iconRect.bottom = iy + iconSize;
> >
> > - DrawBitmapAsync(fBitmap, fBitmap->Bounds(),
> > - iconRect, B_FILTER_BITMAP_BILINEAR);
> > + DrawBitmapAsync(fBitmap, fBitmap->Bounds(), iconRect);
> > }
>
> This would indicate that iconRect != fBitmap->Bounds().
Yep, iconRect is off by one in both dimension, as can almost be seen in the
patch (iconSize is a pixel count, not a distance).
> The scaler is
> never used if the scale is 1. Regardless of the flag. You should have
> replaced the blurred look for a equally bad look with missing or
> repeated pixels.
Probably not quite as bad, as only one row and one column are affected this
way. Though TBH, I find that the least of the visual problems of the whole
thing. I'm taken aback whenever I boot a freshly built image. IMO before R1
something has to be done to make the looks acceptable or the notification
API and server should be removed completely.
CU, Ingo
Other related posts:
