[haiku-commits] Re: r39702 - haiku/trunk/src/add-ons/decorators/SATDecorator

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 02 Dec 2010 16:03:14 +0100

On 2010-12-02 at 15:33:12 [+0100], Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> 
wrote:
> Ingo Weinhold<ingo_weinhold@xxxxxx> wrote:
> > The timing is a bit unfortunate. I planned to revert all my recent app
> > server
> > changes today, since I neither have the time nor the motivation to work on
> > #6925 and #6935 and no one else seems interested either. Since it's not
> > easily possible to separate the decorator changes from my other ones, I'm
> > afraid I'll have to revert your changes, too.
> 
> Are we planning a release in the near future? It's perfectly okay (well...) 
> that changes have temporary regressions. If we want to release the code 
> now, I would be okay in reverting your changes (in the release branch).
> Otherwise I find that pretty much pointless.

Since, at least ATM, most developers use the trunk as their development 
platform or at least their development target, I'm strongly in favor of 
keeping it in a reasonable shape. Yes, I also think temporary regressions are 
acceptable, but only as long as they are worked on and fixed in a timely 
manner, or the regressions are minor compared to the benefits of the change.

In this case the changes only introduced a small new feature and fixed a few 
minor visual S&T glitches while at the same time breaking the cursor key 
workspace navigation, which I personally don't use, but others seem to be 
fond of. Since no one wanted to work on the regressions, I don't find it 
pointless at all to move the feature to a feature branch and remove it from 
trunk for the time being.

> I'll look into #6925 as soon as I'm done with the WiFi stuff. And #6935 
> probably just means that you've uncovered an existing bug.

I believe the same hold true for #6925, respectively the pre-existing code 
undocumentedly hard-codes assumptions and side effects in a way that 
definitely rectifies thorough trout-slapping. :-)

CU, Ingo

Other related posts: