[haiku-commits] Re: r39669 - haiku/trunk/src/apps/terminal
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sun, 28 Nov 2010 18:18:43 +0100
On 2010-11-28 at 18:15:18 [+0100], Adrien Destugues <adestugu@xxxxxxxxx>
wrote:
> >
> > On 2010-11-28 at 17:51:25 [+0100], pulkomandy@xxxxxxxxxxxxxxxxx wrote:
> > > +int32
> > > +BasicTerminalBuffer::GetLineColor(int32 index) const
> > > +{
> > > +// TerminalLine* lineBuffer = ALLOC_LINE_ON_STACK(fWidth);
> >
> > ?
>
> Not sure about this one, it's done this way (without the comment) in
> the method just
> above that I copypasted from, but apparently everything works well
> without it...
I don't see any other occurrence that looks like yours. In the other
instances the stack-allocated buffer is passed to _HistoryLineAt(). If the
variable weren't used, gcc would warn anyway.
CU, Ingo
Other related posts:
