[haiku-commits] Re: r39655 - in haiku/trunk: headers/private/graphics/intel_extreme src/add-ons/kernel/drivers/graphics/intel_extreme
- From: Stephan Aßmus <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 26 Nov 2010 22:06:43 +0100
Hi,
Am Freitag, den 26.11.2010, 21:36 +0100 schrieb
pulkomandy@xxxxxxxxxxxxxxxxx:
> Author: pulkomandy
> Date: 2010-11-26 21:36:40 +0100 (Fri, 26 Nov 2010)
> New Revision: 39655
> Changeset: http://dev.haiku-os.org/changeset/39655
>
> Modified:
> haiku/trunk/headers/private/graphics/intel_extreme/intel_extreme.h
>
> haiku/trunk/src/add-ons/kernel/drivers/graphics/intel_extreme/intel_extreme.cpp
> Log:
> Enable the VBlank interrupt on pipe B for LVDS panels. This gets it working
> for me. Most stuff using BDirectWindowand synced drawing should now work
> better (\n and TVBack demos for example)
Nice work! One remark, though:
> @@ -111,9 +119,8 @@
> thread_id thread = find_thread(NULL);
> thread_info threadInfo;
> if (get_thread_info(thread, &threadInfo) != B_OK
> - || set_sem_owner(info.shared_info->vblank_sem, threadInfo.team)
> != B_OK) {
> + || set_sem_owner(info.shared_info->vblank_sem, threadInfo.team)
> != B_OK)
> status = B_ERROR;
> - }
Please revert this change, since we prefer parenthesis also when the
if-clause itself is multi-line. It makes the code more readable.
Best regards,
-Stephan
Other related posts:
