[haiku-commits] Re: r39578 - haiku/trunk/src/apps/terminal

  • From: "Adrien Destugues" <adestugu@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 27 Nov 2010 22:07:09 +0100

> > > Aren't the lines now one column too wide, and will wrap around
> > > earlier?
> > > Or is that no concern if there aren't any characters afterwards?
> > 
> > The space char is actually inserted, so yes, the line may end up 
> > one
> > char longer.
> > It is possible to not insert this char in this case as there's 
> > nothing
> > displaying wrong.
> > The other problem (raised on IRC) is that the space char may end up 
> > in
> > copypasted text. I'll try with something non-printable such as an 
> > \0
> > and see if that works better, but I don't think the terminal view 
> > is
> > happy displaying non-printable chars...
> 
> This sounds rather hacky (and won't help with the clipboard anyway). 
> Why 
> not add an attributes member for the line break to TerminalLine?

I tried to do that, but apparently there is some line copying occuring 
somewhere
that ends up not copying the extra member. I couldn't spot it anywhere 
in
BasicTerminalBuffer ; any idea where it may happen ?

-- 
Adrien.



Other related posts: