[haiku-commits] Re: r39503 - in haiku/trunk/src/add-ons/translators: . webp webp/webp

  • From: Jérôme Duval <korli@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 19 Nov 2010 15:28:37 +0100

Hi Philippe,

2010/11/19  <philippe.houdoin@xxxxxxxxx>:
> Add a (read-only ATM) WEBP image translator, based on Google's
> libwebp decoding code.

Nice work!
Here are some style issues.


> Added: haiku/trunk/src/add-ons/translators/webp/ConfigView.cpp
> +
> +#include <StringView.h>
> +#include <CheckBox.h>
> +#include <GroupLayout.h>
> +#include <GroupLayoutBuilder.h>

Includes aren't sorted.

> +class ConfigView : public BView {
> +       public:
> +               ConfigView(uint32 flags = B_WILL_DRAW);
> +               virtual ~ConfigView();
> +};

The style isn't correct (same for WebPTranslator.h). Though I know you
might have got another translator as a template for this one (I'm
guilty for one of them at least).


> Added: haiku/trunk/src/add-ons/translators/webp/WEBPTranslator.h
> ===================================================================
> +#ifndef WEBP_TRANSLATOR_H
> +#define WEBP_TRANSLATOR_H
> +
> +#include <ByteOrder.h>

Two blank lines after header guards.

Bye,
Jérôme

Other related posts: