[haiku-commits] Re: r39478 - haiku/trunk/src/apps/terminal
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 19 Nov 2010 22:28:57 +0100
Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> On 2010-11-18 at 19:12:27 [+0100], Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
> > wrote:
> > > * Invalidate the complete tab view after setting a label.
> > > Otherwise
> > > we'd get artifacts when the label gets shorter.
> > That sounds like something the BTabView should be smart enough to
> > do
> > itself.
[...]
> > Why not fix it there?
> Firstly, quite pragmatically, my the change I committed was a one-
> line
> change in an application. What I would have committed was a multi-
> line
> change (since BTab didn't already know the tab view) in a central
> library.
> Secondly, assuming that the current behavior is the same as under
> BeOS,
> nobody would expect it to invalidate the label anyway and would
> therefore
> already have done the invalidation manually. Since BTabView is yet
> another
> of the interface kit's design accidents, I also don't think it's
> worth to
> try and improve it. I'd just keep this binary compatible version and
> start
> a new one from the scratch.
Convincing reasoning :-)
Bye,
Axel.
Other related posts: