[haiku-commits] Re: r39462 - in haiku/trunk: headers/os/app headers/private/app src/kits/app

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 18 Nov 2010 19:22:45 +0100

clemens.zeidler@xxxxxxxxxxxxxx wrote:
> Subclass implementations can use the global restore_window_geometry,
> save_window_geometry function for convenience. Please review. Will 
> commit
> a simple session manager tomorrow.

In addition to the comments from Ingo - why not just use the existing 
archiving mechanism for this?
It should deliver all the needed functionality for this feature.

> +++ haiku/trunk/src/kits/app/Application.cpp  2010-11-17 04:38:48 UTC 
> (rev 39462)
> @@ -572,7 +615,9 @@
>       // supposed to be implemented by subclasses
>  }
>  
> +#include "ApplicationPrivate.h"

Don't use includes in the middle of files, they belong to the start of 
a file unless you have very good reasons.

Bye,
   Axel.


Other related posts: