[haiku-commits] Re: r39414 - haiku/trunk/src/add-ons/kernel/drivers/audio/ac97/es1370
- From: François Revol <revol@xxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Sat, 13 Nov 2010 13:17:55 +0100
Le 13 nov. 2010 à 13:05, Ingo Weinhold a écrit :
> On 2010-11-13 at 01:44:50 [+0100], revol@xxxxxxx wrote:
>> Author: mmu_man
>> Date: 2010-11-13 01:44:50 +0100 (Sat, 13 Nov 2010)
>> New Revision: 39414
>> Changeset: http://dev.haiku-os.org/changeset/39414
>>
>> Modified:
>> haiku/trunk/src/add-ons/kernel/drivers/audio/ac97/es1370/multi.c
>> Log:
>> Copy the buffer_info on buffer exchange so as to avoid getting segfault
>> with interrupts disabled, which at least happened several times here in
>> QEMU.
>
> While the user_memcpy() should be used anyway, calling that ioctl() with
> interrupts disabled is certainly a bug. You might want to look into the
> source of that (now hidden) problem.
It's the code itself that disables interrupts at once time when reading the
struct (the lock() function does it).
> Also, what's with the "#ifdef __HAIKU__"? I thought we were phasing the
> BeOS support out.
Copy-pasted, but yeah...
François.
Other related posts:
