[haiku-commits] Re: r39363 - haiku/trunk/src/add-ons/kernel/drivers/audio/ice1712
- From: François Revol <revol@xxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 9 Nov 2010 01:10:10 +0100
Le 9 nov. 2010 à 00:22, Matt Madia a écrit :
> On 2010-11-08, Jérôme Duval <korli@xxxxxxxxxxxxxxxx> wrote:
>> 2010/11/8 <mattmadia@xxxxxxxxx>:
>>> Author: mmadia
>>> Date: 2010-11-08 22:53:24 +0100 (Mon, 08 Nov 2010)
>>> New Revision: 39363
>>> Changeset: http://dev.haiku-os.org/changeset/39363
>>>
>>> Modified:
>>> haiku/trunk/src/add-ons/kernel/drivers/audio/ice1712/ice1712.c
>>> Log:
>>> Removed the second calling of unreserve_device().
>>> note: r39338 added the call to ice_1712_shutdown()
>>
>> Sorry about that. This is the way it's done in the reference driver.
>
> I based it off the ali5451 driver in r39333, but I'm not sure if it's
> better for unreserve_device() to be called directly in uninit_driver()
> or the shutdown subrountine.
It's really the same anyway, but it's probably better to keep consistency
between drivers.
François.
Other related posts:
