[haiku-commits] Re: r39234 - haiku/trunk/src/add-ons/kernel/file_systems/ext2
- From: Jérôme Duval <korli@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 2 Nov 2010 11:11:40 +0100
2010/11/1 Ingo Weinhold <ingo_weinhold@xxxxxx>:
> I haven't looked at your changes, so just as general hint: Instead of off_t
> I would recommend to use a type that fits your file system (e.g. uint64,
> respectively a typedef for additional clarity) and convert from/to off_t
> where interfacing with the kernel (ideally with range checks to avoid
> overflows).
Yeah, I thought about using some typedefs something like fsblock_t for
filesystem block numbers and fileblock_t for file block numbers...
> At least regarding the use of off_t I wouldn't consider the BFS sources a
> particularly good example.
.. but didn't find them in bfs. Using the same typedefs names would
help reusing code between file systems and reviewing.
Bye,
Jérôme
Other related posts:
