[haiku-commits] Re: r39148 - haiku/trunk/src/add-ons/input_server/filters/shortcut_catcher
- From: "Jonas Sundström" <jonas@xxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 27 Oct 2010 00:29:09 +0000
Axel Dörfler "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx> wrote:
> jonas@xxxxxxxxxxx wrote:
> > + if (!fileEntry.Exists())
> > + BFile file(fFileName, B_READ_ONLY|B_CREATE_FILE);
>
> While this also introduces a style violation, why not also
> monitoring its directory?
> Creating files that aren't needed isn't really the way to go IMO.
I understand your ideal, but I decided that I don't have that
time right now, that this was good enough for now. It doesn't
stop anybody from doing it better.
I expect a majority of people to eventually have this settings
file anyway. We decided a while back IIRC to have something catch
unmapped keys and present a settings panel. Keyboards have these
keys and we can expect people to push them.
Sorry for the style violation. Will fix.
/Jonas.
Other related posts:
