[haiku-commits] r39072 - haiku/trunk/src/apps/debugger/dwarf

  • From: anevilyak@xxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 23 Oct 2010 17:36:36 +0200 (CEST)

Author: anevilyak
Date: 2010-10-23 17:36:36 +0200 (Sat, 23 Oct 2010)
New Revision: 39072
Changeset: http://dev.haiku-os.org/changeset/39072

Modified:
   haiku/trunk/src/apps/debugger/dwarf/DwarfFile.cpp
Log:
Remove a few no longer needed debug traces, and
add a TODO note regarding gcc4's eh_frame format.



Modified: haiku/trunk/src/apps/debugger/dwarf/DwarfFile.cpp
===================================================================
--- haiku/trunk/src/apps/debugger/dwarf/DwarfFile.cpp   2010-10-23 15:35:41 UTC 
(rev 39071)
+++ haiku/trunk/src/apps/debugger/dwarf/DwarfFile.cpp   2010-10-23 15:36:36 UTC 
(rev 39072)
@@ -439,16 +439,20 @@
                // CIE ID/CIE pointer
                uint64 cieID = dwarf64
                        ? dataReader.Read<uint64>(0) : 
dataReader.Read<uint32>(0);
+                       
+               // TODO: gcc4.4+ only specifies an eh_frame by default on 
+               // Haiku, and its format differs from the 2.x format
+               // we currently handle. Support for detecting and parsing 
+               // the appropriate format needs to be added, though this can 
+               // currently be worked around using -fno-dwarf2-cfi-asm
                if (fUsingEHFrameSection
                                ? cieID == 0
                                : (dwarf64
                                        ? cieID == 0xffffffffffffffffULL
                                        : cieID == 0xffffffff)) {
                        // this is a CIE -- skip it
-                       TRACE_CFI("Skipping CIE: %Lx\n", cieID);
                        previousCIE = entryOffset;
                } else {
-                       TRACE_CFI("Found FDE\n");
                        // this is a FDE
                        target_addr_t initialLocation = 
dataReader.ReadAddress(0);
                        target_size_t addressRange = dataReader.ReadAddress(0);


Other related posts:

  • » [haiku-commits] r39072 - haiku/trunk/src/apps/debugger/dwarf - anevilyak