[haiku-commits] r39066 - haiku/branches/developer/aldeck/tracker_layout/src/kits/tracker

  • From: alex@xxxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sat, 23 Oct 2010 14:00:41 +0200 (CEST)

Author: aldeck
Date: 2010-10-23 14:00:41 +0200 (Sat, 23 Oct 2010)
New Revision: 39066
Changeset: http://dev.haiku-os.org/changeset/39066

Modified:
   
haiku/branches/developer/aldeck/tracker_layout/src/kits/tracker/FilePanelPriv.cpp
Log:
* Create a groupview for the menufield outside of the BLayoutBuilder so that we 
get a chance to set its background color, and avoid a bogus one 
pixel white border.


Modified: 
haiku/branches/developer/aldeck/tracker_layout/src/kits/tracker/FilePanelPriv.cpp
===================================================================
--- 
haiku/branches/developer/aldeck/tracker_layout/src/kits/tracker/FilePanelPriv.cpp
   2010-10-23 11:45:34 UTC (rev 39065)
+++ 
haiku/branches/developer/aldeck/tracker_layout/src/kits/tracker/FilePanelPriv.cpp
   2010-10-23 12:00:41 UTC (rev 39066)
@@ -656,24 +656,30 @@
        // layout
        const float spacing = be_control_look->DefaultItemSpacing();
        
-       BGroupView* buttonsGroup = new BGroupView(B_HORIZONTAL, spacing);       
+       BGroupView* buttonsGroup = new BGroupView(B_HORIZONTAL, spacing);
        if (fIsSavePanel)
-               buttonsGroup->AddChild(fTextControl);           
-       else
-               
buttonsGroup->GroupLayout()->AddItem(BSpaceLayoutItem::CreateGlue(), 1.0f);
+               buttonsGroup->AddChild(fTextControl);
+       else {
+               buttonsGroup->GroupLayout()->AddItem(
+                       BSpaceLayoutItem::CreateGlue(), 1.0f);
+       }
 
        buttonsGroup->AddChild(cancelButton);
        buttonsGroup->AddChild(defaultButton);
        buttonsGroup->GroupLayout()->SetInsets(0, 0, 14, 0);
        
+       BGroupView* dirMenuGroup = new BGroupView(B_HORIZONTAL);
+       dirMenuGroup->GroupLayout()->View()->SetViewColor(
+               ui_color(B_PANEL_BACKGROUND_COLOR));
+       dirMenuGroup->GroupLayout()->AddView(fDirMenuField, 0.0f);
+               // 0.0 wheigth so that the menu keeps its width minimal
+       dirMenuGroup->GroupLayout()->AddItem(
+               BSpaceLayoutItem::CreateGlue(), 1.0f);
+       
        BLayoutBuilder::Group<>(this, B_VERTICAL, 0.0f)
                .Add(Controller()->MenuBar())
                .AddGroup(B_VERTICAL)
-                       .AddGroup(B_HORIZONTAL)
-                               .Add(fDirMenuField, 0.0f)
-                                       // 0.0 wheigth makes menu width to be 
always minimal
-                               .AddGlue()
-                       .End()          
+                       .Add(dirMenuGroup)
                        .AddGroup(B_VERTICAL, 0.0f)
                                .Add(Controller()->TitleView())         
                                .AddGroup(B_HORIZONTAL, 0.0f)
@@ -687,7 +693,7 @@
                                                // avoid the window's resize 
handle
                                .End()
                        .End()
-                       .Add(buttonsGroup)              
+                       .Add(buttonsGroup)
                .SetInsets(spacing, spacing, spacing, spacing)
                .End();
        


Other related posts:

  • » [haiku-commits] r39066 - haiku/branches/developer/aldeck/tracker_layout/src/kits/tracker - alex