[haiku-commits] Re: r38956 - haiku/trunk/src/system/boot/platform/amiga_m68k
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 12 Oct 2010 13:37:12 +0200
François Revol <revol@xxxxxxx> wrote:
> Le 12 oct. 2010 à 12:16, Axel Dörfler a écrit :
> > revol@xxxxxxx wrote:
> >> + uint16 AttnFlags = SysBase->AttnFlags;
> > Coding style; variables are lower cased. And that is also true for
> > structure fields, btw.
> but it's just a local copy of an existing system variable...
And?
> >> + if (AttnFlags & AFF_68881)
> > Coding style: use (attentionFlags & AFF_68881) != 0 instead.
> tsss
I'm pretty sure you can still find a related operator precendence error
when scanning our codebase - I already found and fixed more than a
dozen because of those missing parenthesis. Getting used to always use
those parenthesis is definitely nothing to tsss over - it just makes
sense.
Bye,
Axel.
Other related posts:
