[haiku-commits] Re: r38765 - haiku/trunk/src/apps/mediaplayer/interface
- From: "Stephan Assmus" <superstippi@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Thu, 23 Sep 2010 10:14:01 +0200
Hi,
Von: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
> "Stephan Assmus" <superstippi@xxxxxx> wrote:
> > Von: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
> > > Why not just take over the volume slider of desklink?
> > That's already where I copied some code from (the snapping, although
> > improved).
>
> Ah, what exactly did you improve? I did not even notice that the volume
> slider snaps at all, and I think it's a bit too subtle (but that's
> probably only because of the missing feedback).
The snapping is based on mouse travel distance in my code, not on the slider
values. So it's actually more consistently noticeable in my version...
> > The DeskLink one controls the mixer output, I really liked it if it
> > would find
> > the correct MediaPlayer mixer input and controlled that instead of
> > implementing volume itself.
>
> That should indeed be better set from outside the class.
>
> > At the time, I was too lazy to look into it, and also there seems to
> > be the
> > problem that notifications do not work properly?
>
> Not that I know of; at least it seems to work nicely when using the
> master volume (and for other stuff as well). I don't know how the media
> player controls its volume, but it seems to be independent from its
> output node for whatever reason.
> Also, I like the linear dB volume slider a lot more than what VLC and
> the MediaPlayer are currently doing.
When I tried it last time, the slider did not pick up changes live when
modifying the volume via the Media preflet. That was basically the main reason
why I didn't put more energy into making this a proper solution. I didn't feel
like debugging a different component at the time. IIRC, what I tried was to put
the volume replicant onto the Desktop and then change the volume from either
the volume replicant in the Deskbar, or the Media preflet. The slider in the
Media preflet will also not update when you change the volume via the Deskbar.
Oh, when I tried it a second time just now, that worked. However the slider on
the desktop never updated in my tests.
Best regards,
-Stephan
Other related posts:
