[haiku-commits] Re: r38541 - in haiku/trunk: build/jam src/add-ons/media/plugins/ffmpeg

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 06 Sep 2010 12:00:38 +0200

Am 06.09.2010 11:50, schrieb superstippi@xxxxxx:
Author: stippi
Date: 2010-09-06 11:50:24 +0200 (Mon, 06 Sep 2010)
New Revision: 38541
Changeset: http://dev.haiku-os.org/changeset/38541

Modified:
    haiku/trunk/build/jam/HaikuImage
    haiku/trunk/src/add-ons/media/plugins/ffmpeg/DemuxerTable.cpp
Log:
Remove the Matroska reader from the image and enable
Matroska support in the FFmpeg plugin. I have a few streams
to test with, most didn't play right with the Matroska reader,
many simply crash. With the FFmpeg matroska support, most files
do play fine.
[...]

Forgot to mention that one of the problems of the Matroska reader is that FindKeyFrame() has the exact same implementation as Seek(). Obviously FindKeyFrame() is supposed to be a read-only operation, which only informs the caller of seekable frames/times, *not* does the seeking already. I've quickly looked in the matroska lib to find an API for this, but only found the seeking API.

Best regards,
-Stephan

Other related posts: