[haiku-commits] Re: r38439 - haiku/trunk/src/apps/mediaplayer

  • From: Stephan Assmus <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 30 Aug 2010 12:11:38 +0200

Am 30.08.2010 11:59, schrieb Axel Dörfler:
superstippi@xxxxxx wrote:
Log:
For videos that are longer than 240 frames, we anticipate
that the graphical precision of the seeking slider is not
enough to seek to individual frames on purpose. So we filter
the requested seeking position to keyframes if there is a
video track. The difference in snappiness when seeking is
like night and day.

Shouldn't you check how far away the key frame is from the original
target? I mean it's only important for bad quality movies with larger
time spans between key frames, but the difference might be noticeable.

What would be the gain? If the seek slider is imprecise anyway, why make the code more complicated and potentially slower?

Best regards,
-Stephan


Other related posts: