[haiku-commits] Re: r38346 - haiku/trunk/src/apps/mediaconverter

  • From: "Stephan Assmus" <superstippi@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 25 Aug 2010 11:16:10 +0200

-------- Original-Nachricht --------
> Datum: Wed, 25 Aug 2010 01:10:45 +0200 (CEST)
> Von: yourpalal2@xxxxxxxxx
> An: haiku-commits@xxxxxxxxxxxxx
> Betreff: [haiku-commits] r38346 - haiku/trunk/src/apps/mediaconverter

> Author: yourpalal
> Date: 2010-08-25 01:10:44 +0200 (Wed, 25 Aug 2010)
> New Revision: 38346
> Changeset: http://dev.haiku-os.org/changeset/38346
> Ticket: http://dev.haiku-os.org/ticket/4197
> 
> Added:
>    haiku/trunk/src/apps/mediaconverter/MediaFileInfo.cpp
>    haiku/trunk/src/apps/mediaconverter/MediaFileInfo.h
> Removed:
>    haiku/trunk/src/apps/mediaconverter/StatusView.cpp
>    haiku/trunk/src/apps/mediaconverter/StatusView.h
> Modified:
>    haiku/trunk/src/apps/mediaconverter/Jamfile
>    haiku/trunk/src/apps/mediaconverter/MediaConverterApp.cpp
>    haiku/trunk/src/apps/mediaconverter/MediaConverterWindow.cpp
>    haiku/trunk/src/apps/mediaconverter/MediaConverterWindow.h
>    haiku/trunk/src/apps/mediaconverter/MediaFileInfoView.cpp
>    haiku/trunk/src/apps/mediaconverter/MediaFileInfoView.h
>    haiku/trunk/src/apps/mediaconverter/MediaFileListView.cpp
>    haiku/trunk/src/apps/mediaconverter/MediaFileListView.h
> Log:
> *Update MediaConverter to use the Layout API
> *Replace StatusView class with BStringView
> *Rename some variables (fBox1 -> fSourcesBox, for example)
> *Create MediaFileInfo struct to cache strings for media files, these were
>       previously created on each call to MediaFileInfoView::Draw()
> *Update MediaFileInfoView class for layout-friendliness and hopefully
>       better performance.
> *Update other classes for layout-friendliness as well (just remove BRect
> and
>       resizeFlags params)
> *Add keyboard accels for Open and Quit items in menuBar
> *closes #4197
> *fixes CIDs 1545 and 1455

You rock! Glad we have won a contributor, hopefully even more, after GSoC! :-)

Best regards,
-Stephan

Other related posts: