[haiku-commits] r38279 - haiku/trunk/src/add-ons/translators/wonderbrush

  • From: zooey@xxxxxxxxxxxxxxx
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Thu, 19 Aug 2010 21:40:15 +0200 (CEST)

Author: zooey
Date: 2010-08-19 21:40:15 +0200 (Thu, 19 Aug 2010)
New Revision: 38279
Changeset: http://dev.haiku-os.org/changeset/38279

Modified:
   haiku/trunk/src/add-ons/translators/wonderbrush/Layer.cpp
Log:
* fix a warning in the wonderbrush translator which I think indicates an actual
  problem (since + binds stronger than >>)
Stephan: please review, esp since I don't know how to test this!


Modified: haiku/trunk/src/add-ons/translators/wonderbrush/Layer.cpp
===================================================================
--- haiku/trunk/src/add-ons/translators/wonderbrush/Layer.cpp   2010-08-19 
19:33:54 UTC (rev 38278)
+++ haiku/trunk/src/add-ons/translators/wonderbrush/Layer.cpp   2010-08-19 
19:40:15 UTC (rev 38279)
@@ -78,7 +78,7 @@
                                for (int32 x = left; x <= right; x++) {
                                        if (srcHandle[3] > 0) {
                                                uint8 c1 = dstHandle[0] * 
srcHandle[0] >> 8;
-                                               c1 = c1 + dstHandle[0] * (
+                                               c1 += dstHandle[0] * (
                                                                255 - (
                                                                        (255 - 
dstHandle[0])
                                                                        * (255 
- srcHandle[0])
@@ -90,7 +90,7 @@
                                                        ) >> 8;
 
                                                uint8 c2 = dstHandle[1] * 
srcHandle[1] >> 8;
-                                               c2 = c2 + dstHandle[1] * (
+                                               c2 += dstHandle[1] * (
                                                                255 - (
                                                                        (255 - 
dstHandle[1])
                                                                        * (255 
- srcHandle[1])
@@ -102,7 +102,7 @@
                                                        ) >> 8;
 
                                                uint8 c3 = dstHandle[2] * 
srcHandle[2] >> 8;
-                                               c3 = c3 + dstHandle[2] * (
+                                               c3 += dstHandle[2] * (
                                                                255 - (
                                                                        (255 - 
dstHandle[2])
                                                                        * (255 
- srcHandle[2])


Other related posts:

  • » [haiku-commits] r38279 - haiku/trunk/src/add-ons/translators/wonderbrush - zooey