[haiku-commits] Re: r38133 - haiku/trunk/src/apps/terminal
- From: Stefano Ceccherini <stefano.ceccherini@xxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 16 Aug 2010 12:19:43 +0200
2010/8/16 Stefano Ceccherini <stefano.ceccherini@xxxxxxxxx>:
> 2010/8/16 Stefano Ceccherini <stefano.ceccherini@xxxxxxxxx>:
>> 2010/8/16 Ithamar R. Adema <ithamar.adema@xxxxxxxxxxxxxxxx>:
>
>> The code should be centralized and used in the TermWindow::AddTab().
>
> Or, better: in Shell::Spawn().
>
Actually, since the default shell is set in a couple gazillions files,
a refactoring would be better: just put the code in Shell::Spawn(),
and remove it from TermApp::TermApp(). TermApp could just pass NULL
arguments in case no arguments were passed on the commandline, and
Shell::Spawn() would handle gracefully that case, and launch the user
preferred shell, or "sh" if there is none.
Other related posts:
