[haiku-commits] Re: r38067 - haiku/trunk/src/servers/app

  • From: "Clemens Zeidler" <clemens.zeidler@xxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 13 Aug 2010 09:44:43 +1200

Am 13.08.2010, 09:30 Uhr, schrieb Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>:

clemens.zeidler@xxxxxxxxxxxxxx wrote:
+       InvokeSetWindowTabLocation(window, location);

I find the word "Invoke" to be absolutely wrong and misleading here.
For listeners, it should be past tense, like WindowTabLocationChanged().

+       FOR_ALL_DESKTOP_LISTENER
+               listener->SetWindowTabLocation(window, location);

Please don't use macros this way in code that you don't maintain alone.
We're not BSD, the absence of macros is intentional :-)

Bye,
   Axel.



ok, no objections will fix it later..

Other related posts: