[haiku-commits] Re: r37787 - in haiku/trunk/src: kits/locale tests/kits/locale

From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
To: haiku-commits@xxxxxxxxxxxxx
Date: Wed, 28 Jul 2010 16:41:55 +0200

pulkomandy@xxxxxxxxxxxxxxxxx wrote:
> +     Collator::ECollationStrength icuStrength;
> +     switch(strength) {

Missing space.

> -     return B_OK;
> +     if (error == U_ZERO_ERROR)
> +             return B_OK;
> +     else
> +             return B_ERROR;

Superfluous "else" that hurts readability IMO.

Bye,
   Axel.

References:
- [haiku-commits] r37787 - in haiku/trunk/src: kits/locale tests/kits/locale
  - From: pulkomandy

Other related posts:

» [haiku-commits] r37787 - in haiku/trunk/src: kits/locale tests/kits/locale- pulkomandy
» [haiku-commits] Re: r37787 - in haiku/trunk/src: kits/locale tests/kits/locale - Axel Dörfler