[haiku-commits] Re: r37534 - haiku/trunk/src/system/kernel/slab
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 16 Jul 2010 15:25:35 +0200
On 2010-07-16 at 04:56:28 [+0200], Rene Gollent <anevilyak@xxxxxxxxx> wrote:
> On Thu, Jul 15, 2010 at 9:27 PM, <ingo_weinhold@xxxxxx> wrote:
> > Author: bonefish
> > Date: 2010-07-16 03:27:27 +0200 (Fri, 16 Jul 2010)
> > New Revision: 37534
> > Changeset: http://dev.haiku-os.org/changeset/37534
> >
> > * ObjectCache::InitSlab(): Slab coloring *was* done when
> > CACHE_ALIGN_ON_SIZE
> > was given, i.e. exactly the wrong way around. Also the cache_color_cycle
> > computation was weird -- color 0 was used twice in a row.
>
> Nice catch! Out of curiosity, the slab coloring problems couldn't in
> any way have instigated or influenced the circumstances leading to
> ticket #6237 could they?
No, I don't think there had been any negative effect. It would only have
affected memalign() allocations, which are very rare in the kernel -- as far
as I've seen there are only 4 KB allocations which would exactly fit a slab
and thus not leave and spare bytes for coloring anyway.
CU, Ingo
Other related posts:
