[haiku-commits] Re: r37413 - haiku/trunk/src/servers/app

  • From: PulkoMandy <pulkomandy@xxxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 7 Jul 2010 12:15:16 +0200

> Note, that once there are more than one fall back font, the locking 
> order must be enforced in order to avoid deadlocks.

Yes, I'll try to clean up the locking and caching a little, to avoid
locking the fallback cache for each missing character.

> I miss a check "fallbackEntry == entry"; no need to double lock, and do 
> the double work. At least the outer entry must be write locked at this 
> point, or this would easily cause dead locks.
> 

Yes, looks like a good idea.

> BTW are you planning to leave the broken Deskbar settings as is, or are 
> you working on this? At least a reply to my mail on this matter would 
> be appreciated.

I'm not sure how to do it, do you think it's better to switch to a
BMessage based system ; or just keep the unused settings around ?

Sorry for not answering, I had some trouble getting a reliable internet
access and sending mails, should be better now.



Other related posts: