[haiku-commits] Re: r36839 - haiku/branches/features/stack-and-tile/src/servers/app

  • From: "Clemens Zeidler" <clemens.zeidler@xxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 18 May 2010 09:48:39 +1200

Hi Stephan,


+    //For each previously snapped window, make sure that it is within
+    //screen bounds, so as to prevent it from being lost off-screen

There are lots of comments in the code that are missing a space in front.

Yes I only moved all code from Window into a separate class, just to get it somehow separated. Will take a look at the coding style later, but thanks for pointing it out.


The above looks in desperate need for refactoring. :-) Also I am wondering if
_FindWindow() is a performance problem. Can't the list store the Window
pointer directly? I am probably missing something. If stale pointers are a problem then perhaps some mechanism can be introduced to keep these lists up
to date automatically.
That was also my thought, will take a look at it.

My idea is to create an interface in the app server code where a component like stack and tile can be registered to receive the necessary events. At the moment these are:
- key down / up
- mouse down /up
- window moved
- window resized
- window activated
- get / set decorator settings
So the interface is quite small at the moment and I hope I can separate SAT almost completely from the rest of the app server code. What do you think?

After that I will refactor the SAT code, there are also some problems with the memory allocation which need some bigger changes...

Regards,
        Clemens


Other related posts: