[haiku-commits] Re: r36762 - haiku/trunk/src/kits/tracker

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 09 May 2010 01:12:30 +0200

On 2010-05-09 at 00:41:55 [+0200], superstippi@xxxxxx wrote:
> Author: stippi
> Date: 2010-05-09 00:41:55 +0200 (Sun, 09 May 2010)
> New Revision: 36762
> Changeset: http://dev.haiku-os.org/changeset/36762/haiku
> 
> Modified:
>    haiku/trunk/src/kits/tracker/ContainerWindow.cpp
> Log:
> Don't open context menus right under the mouse so that the first item is
> already selected and get's picked when the user releases the mouse right 
> after
> the initial click. For model context menus, like right clicking a mounted 
> disk
> on the desktop, this somehow worked without selecting the item. But opening
> the context menu on an empty part of the desktop always selected the Desktop
> entry which resulted in the menu immediately closing without any effect. The
> perhaps unwanted side-effect of this change is that navigation menus don't
> automatically open unless you move the mouse a bit. Please play with this a 
> bit
> before commiting to alpha branch. I remember having to move the mouse a bit
> on R5 as well, but could be wrong about it.

You remember correctly. I played a bit with it and it definitely improves the 
situation -- right click on the desktop just didn't work at all. The only 
regression (or feature?) I've noticed (might not even have been introduced in 
this commit) is that after right-click opening a context menu, a right click 
at another location (e.g. the desktop) closes the menu (as expected) and 
opens a new context menu at the new location.

CU, Ingo

Other related posts: