[haiku-commits] Re: r36715 - haiku/trunk/src/preferences/locale

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 07 May 2010 21:07:01 +0200

On 2010-05-07 at 19:41:55 [+0200], Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> 
wrote:
> Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> > On 2010-05-07 at 13:31:10 [+0200], axeld@xxxxxxxxxxxxxxxx wrote:
> > > Author: axeld
> > > Date: 2010-05-07 13:31:10 +0200 (Fri, 07 May 2010)
> > > New Revision: 36715
> > > Changeset: http://dev.haiku-os.org/changeset/36715/haiku
> > > 
> > > Modified:
> > >    haiku/trunk/src/preferences/locale/TimeFormatSettingsView.cpp
> > > Log:
> > > * Made the spacing a bit larger in general, and made it use
> > >   BControlLook::DefaultItemSpacing() instead of hard coded values.
> > > * Minor cleanup.
> > Do you want this change in the alpha 2 release? Due to the cleanup,
> > which
> > conflicts with the B_TRANSLATE* changes, it would have to be
> > backported
> > manually.
> 
> That means you don't plan to move the B_TRANSLATE*() changes into alpha
> 2?

That's right.

> Why is that?

The changes provide no immediate benefit for the release, but touch a lot 
of code. Both being good reasons for not merging them into the branch a day 
before tagging it.

> Also, I've fixed bugs #5896, and vastly improved the situation for
> #5897 in r36727 - which would also be nice to have it in the release; I
> didn't find the time to do that earlier, sorry.

Phew, while the changes sound nice, they would get virtually no testing 
anymore. The change set also doesn't qualify as small or fixing anything 
serious. So I'd rather not merge it anymore.

CU, Ingo

Other related posts: