[haiku-commits] Re: r36656 - haiku/trunk/src/apps/stylededit
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Fri, 07 May 2010 08:59:09 +0200
Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> On 2010-05-06 at 17:35:51 [+0200], axeld@xxxxxxxxxxxxxxxx wrote:
> > +#define ATTRNAME_SE_INFO "se-info"
> Do attribute names have to be cryptic?
No, not really, but I guess the original author followed Pe's naming
scheme (ie. pe-info), and I was too lazy to think of something better.
Short names have the advantage that they take less space, though ;-)
Will replace with StyledEdit-info unless there are better suggestions.
> > void
> > +StyledEditWindow::LoadAttrs()
> > +{
> > + if (!fSaveMessage)
> > + return;
> Do I want to know why the window has this mystic fSaveMessage
> attribute or
> better not?
I don't know, I just applied the patch ;-)
While the name is a bit misleading, it just mean that the file has a
known location (so that "Save" does not have to mimic "Save As"). It's
not necessary at the top of LoadAttrs(), as that's only used when there
actually is a location in the first place.
Bye,
Axel.
Other related posts:
