[haiku-commits] Re: r36596 - haiku/trunk/src/apps/packageinstaller

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 04 May 2010 12:41:50 +0200

Stephan Assmus <superstippi@xxxxxx> wrote:
> On 2010-05-04 at 08:34:35 [+0200], Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
> > wrote:
> > > Coding style requires it for multi-line if-statemens, which also
> > > goes
> > > for if-statements where just the if-clause itself makes it multi-
> > > line.
> > Actually, this is not the case. It's just something you and Ingo do
> > because you think it increases readability :-)
> It does not explicitely mention this case, but the only example that
> comes
> close suggests the use of parenthesis, and I find it makes perfect
> sense.
> Why make rules more complicated than they need to be?

It's just not in the coding style, that's all. Making a rule more
complex than need to be is what you're doing here (by interpreting it
incorrectly).
The rule itself is pretty simple: multi-line statements are enclosed
with curly braces; the rule doesn't say that multi-line
if/for/while/... statements are followed by curly braces even if the
statement inside is only a single line statement. I don't see any room
for ambiguity here.

Anyway, personally, I don't mind that one, although I don't think it
makes a difference wrt readability.

Bye,
   Axel.


Other related posts: