[haiku-commits] Re: r36499 - haiku/trunk/src/apps/resedit

  • From: DarkWyrm <darkwyrm@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 27 Apr 2010 07:00:26 -0400

Jérôme Duval wrote:

Hi DarkWyrm,

2010/4/27  <darkwyrm@xxxxxxxxx>:

Modified: haiku/trunk/src/apps/resedit/ResView.cpp
 #include <Application.h>
+#include <File.h>
 #include <ScrollView.h>
-#include <MenuBar.h>
+#include <malloc.h>
 #include <Menu.h>
 #include <MenuItem.h>
 #include <stdio.h>
-#include <ColumnTypes.h>
+#include <TranslatorRoster.h>
+#include <TypeConstants.h>
+#include "ColumnTypes.h"


Posix headers should be on their own block.


+                       while (msg->FindRef("refs",i++,&ref) == B_OK)


There is a space after each comma. There are occurrences of this style
everywhere in these files btw.


Axel Dörfler wrote:
> Jérôme Duval <korli@xxxxxxxxxxxxxxxx> wrote:
>>> +#include <malloc.h>
>
> Also, don't use <malloc.h>, it's deprecated for years, use <stdlib.h>
> instead - newer compilers actually throw warnings for that include.
OK. Thanks for pointing these out, guys. It's been a while since I wrote Haiku style, so I'm obviously missing a few things. Thanks! 

--DarkWyrm

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 04-2010