[haiku-commits] Re: r36472 - haiku/trunk/src/apps/mediaplayer/media_node_framework/audio
- From: Simon Taylor <simontaylor1@xxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Mon, 26 Apr 2010 11:05:02 +0100
Jérôme Duval wrote:
> 2010/4/26 Ingo Weinhold <ingo_weinhold@xxxxxx>:
>> On 2010-04-26 at 10:21:40 [+0200], Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
>> wrote:
>>> korli@xxxxxxxxxxxxxxxx wrote:
>>>> + int b = *(int*)buffer;
>>>> + if (b == -2147483648LL)
>>> BTW there are some useful macros in limits.h and stdint.h that would
>>> make this even clearer :-)
>> Besides that it is weird to compare an int with a long long.
>
> Perhaps it's as weird as comparing a short with an int.
> without LL gcc warns it's so large that it becomes unsigned. How is
> INT_MIN defined btw ?
#define INT_MIN = -(INT_MAX-1) from limits.h, seems weird that gcc warns
about it without the LL though.
Also, it looks like the test in the ReadChar (line 68) is wrong- should
be if (b == -128)
Simon
>
> Bye,
> Jérôme
>
Other related posts:
