[haiku-commits] Re: r36356 - haiku/trunk/src/system/libroot/posix/sys
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Tue, 20 Apr 2010 17:41:16 +0200
On 2010-04-19 at 19:12:44 [+0200], korli@xxxxxxxxxxxxxxxx wrote:
> Author: korli
> Date: 2010-04-19 19:12:44 +0200 (Mon, 19 Apr 2010)
> New Revision: 36356
> Changeset: http://dev.haiku-os.org/changeset/36356/haiku
> Ticket: http://dev.haiku-os.org/ticket/5759
>
> Modified:
> haiku/trunk/src/system/libroot/posix/sys/utimes.c
> Log:
> * fixed utimensat() when times is NULL, both the access and modification
> timestamps should be set (bug #5759).
> * the meaning of AT_SYMLINK_NOFOLLOW was also reversed.
>
>
> Modified: haiku/trunk/src/system/libroot/posix/sys/utimes.c
> ===================================================================
> --- haiku/trunk/src/system/libroot/posix/sys/utimes.c 2010-04-19
> 16:29:23 UTC (rev 36355)
> +++ haiku/trunk/src/system/libroot/posix/sys/utimes.c 2010-04-19
> 17:12:44 UTC (rev 36356)
> @@ -54,6 +54,7 @@
> bigtime_t now = real_time_clock_usecs();
> stat.st_atim.tv_sec = stat.st_mtim.tv_sec = now / 1000000;
> stat.st_atim.tv_nsec = stat.st_mtim.tv_nsec = (now % 1000000) *
> 1000;
> + mask |= B_STAT_ACCESS_TIME | B_STAT_MODIFICATION_TIME;
> }
This change is not correct. Now both flags are also set when times != NULL
and one of the times is UTIME_OMIT. Could be moved to an "else" of the
following "if".
CU, Ingo
Other related posts:
