[haiku-commits] Re: r36059 - haiku/trunk/src/system/kernel/arch/x86
- From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 07 Apr 2010 19:57:59 +0200
clemens.zeidler@xxxxxxxxxxxxxx wrote:
> Added:
> haiku/trunk/src/system/kernel/arch/x86/irq_routing_table.cpp
> haiku/trunk/src/system/kernel/arch/x86/irq_routing_table.h
> Modified:
> haiku/trunk/src/system/kernel/arch/x86/Jamfile
> haiku/trunk/src/system/kernel/arch/x86/arch_int.cpp
> Log:
> Rescue acpi irq stuff from my defect laptop. Code is disabled and
> should't to any harm.
Finally something to look at - what happened to your laptop?
Pointing out some typos:
> + status_t status;
> + acpi_module_info* acpiModule;
> + status = get_module(B_ACPI_MODULE_NAME,
> (module_info**)&acpiModule);
Rather have the status definition and assignment in one line?
> + if (status != B_OK) {
> dprintf("acpi module not available, not configuring
> ioapic\n");
> return;
> }
> + BPrivate::CObjectDeleter<const char, status_t>
> + acpiModulePutter(B_ACPI_MODULE_NAME, put_module);
> + // load pci modul
modul*e*
> + for (int i = 0; i < table.Count(); i++) {
> + irq_routing_entry& entry = table.ElementAt(i);
> + irq_discriptor irqDiscriptor;
descriptor, not discriptor.
Bye,
Axel.
Other related posts:
