[haiku-commits] Re: r35937 - haiku/trunk/build/jam

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 24 Mar 2010 16:12:48 +0100

Matt Madia <mattmadia@xxxxxxxxx> wrote:
> On Wed, Mar 24, 2010 at 05:30, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
> wrote:
> > mattmadia@xxxxxxxxx wrote:
> >> +             if $(HAIKU_GCC_VERSION[1]) = 2 {
> >> +                     AddSymlinkToHaikuHybridImage
> > Shouldn't that be:
> >        if $(HAIKU_GCC_VERSION[1]) = 2 && $(isHybridBuild) {
> >                AddSymlinkToHaikuHybridImage
> >                        ...
> I could be understanding it incorrectly,   but ' || ' is needed so
> that the archive is added to gcc2, gcc2hybrid, and gcc4hybrid. Even
> though 'AddSymlinkToHaikuHybridImage' is used, it calls both
> 'AddSymlinkToHaikuImage' & 'AddSymlinkToAlternativeGCCArchive'.  The
> inner "if $(HAIKU_GCC_VERSION[1]) = 2 {" ensures that the symlink is
> only created once. In the case of gcc4hybrid, it's sub jam process
> for
> the alternative gcc libs will create it.

I only meant the inner "if", I only added the rest for the context :-)
So AddSymlinkToHaikuHybridImage works also fine for non-hybrid images,
and won't add the other symlinks then?

Bye,
   Axel.


Other related posts: