[haiku-commits] Re: r35860 - haiku/trunk/data/image_directories

  • From: Michael Pfeiffer <michael.w.pfeiffer@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Sun, 14 Mar 2010 20:54:48 +0100

Am 14.03.2010 um 18:42 schrieb Humdinger:

> -- Michael Pfeiffer, on Sun, 14 Mar 2010 16:41:43 +0100:
>>> -resource(3, "transport") "Print to file";
>>> +resource(3, "transport") "Print To File";
>> Humdinger, if you want to change the name here, you
>> also have to change the file name of the "Print To File" printer
>> transport add-on (src/add-ons/print/transports/print_to_file).
> I see, sorry, I missed that. I blame that I always TextSearched for 
> "print to file" when the thing to change is actually in the jamfile as 
> "Print\ To\ File"...
> BTW, there's also an occurance in src/servers/print/ResourceManager.
> cpp, if that's relevant too:
> @@ -33,7 +33,7 @@
>       // or in case of "Preview" printer it
>       // is set on R5 to "NONE" IIRC and the Haiku
>       // preflet sets an empty string.
> -     return !(fTransport == "Print To File" 
> +     return !(fTransport == "Print to file" 
>               || fTransport == "NONE"
>               || fTransport == ""); 
> I still think it should be "Print to file". Should I try to do it right 
> this time, or do you disagree and it should be left "Print To File"? Or 
> do you want to make sure it's done correctly and do it yourself. :)

Go ahead if you think sentence case is the right thing for file names too.

I hope sometime in the future Haiku will support localization of file names, as 
I mention in another thread, and then the proper solution for that problem 
could be implemented.

> BTW, the folder /boot/system/add-ons/Print/ should also be ".../print/" 
> to better fit the other add-ons folders.

That's because of backwards compatibility. It could be dropped, if all third 
party printer drivers, could be installed into ".../print" and would work from 
there too.

- Michael

Other related posts: