[haiku-commits] Re: r35830 - in haiku/trunk: . build/jam

  • From: Ingo Weinhold <ingo_weinhold@xxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Fri, 12 Mar 2010 20:29:59 +0100

On 2010-03-12 at 20:43:34 [+0100], Matt Madia <mattmadia@xxxxxxxxx> wrote:
> On Fri, Mar 12, 2010 at 13:56, Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> > On 2010-03-12 at 19:07:19 [+0100], mattmadia@xxxxxxxxx wrote:
> >> Author: mmadia
> >> Date: 2010-03-12 19:07:19 +0100 (Fri, 12 Mar 2010)
> >> New Revision: 35830
> >> Changeset: http://dev.haiku-os.org/changeset/35830/haiku
> >>
> >> Modified:
> >>    haiku/trunk/Jamfile
> >>    haiku/trunk/build/jam/HaikuImage
> >> Log:
> >> Moves the conditional adding of OpenSSL from HaikuImage to the root 
> >> Jamfile.
> >>
> > Admittedly that's all not particularly nice. A better solution would be to
> > adjust AddOptionalHaikuImagePackages and OptionalPackageDependencies to 
> > work
> > in arbitrary order. For that to work the list of (immediate) dependencies 
> > for
> > each package would need to be tracked and AddOptionalHaikuImagePackages 
> > would
> > need to work recursively.
> 
> In the short term, could this be applied while I figure out the better 
> solution?

OptionalPackageDependencies should be included after all 
AddOptionalHaikuImagePackages invocations, including the one for OpenSSL. It 
still works (and did work before r35830) in this case, since OpenSSL doesn't 
have any dependencies, but I'd prefer the correct order nonetheless.

CU, Ingo

Other related posts: