[haiku-commits] Re: r35782 - in haiku/trunk: headers/os/app headers/private/app src/kits/app src/servers/app src/servers/app/drawing

  • From: Ryan Leavengood <leavengood@xxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 8 Mar 2010 14:20:32 -0500

On Sun, Mar 7, 2010 at 6:12 PM,  <superstippi@xxxxxx> wrote:
> Author: stippi
>
>  * Added BCursorID enumeration in App Kit's Cursor.h and new constructor which
>   takes such an id.
>  * Reused the existing mechanism to to have hardcoded tokens for the system
>   cursors, i.e. removed cursor_which enumeration from ServerProtocol.h and
>   used BCursorID where cursor_which was previously used.

Why did you use BCursorID instead of keeping cursor_which?

> I hope I will not get too much beating for this one... :-) I know the new
> default cursor is slightly larger, but I believe the old one was just too 
> small.
> Also I noticed that the cursor may be slightly too dark, at least the old one
> seems noticeably brighter when compared side by side (the new one has a slight
> gradient). That is something I may correct at least. Otherwise I hope nothing
> is broken, I've tested in QEMU and so far everything works as intended.

I like the bigger size and the color and brightness seems fine to me.
But to my eye the thumb seems a bit too big on the default pointer
cursor, such that it looks more like a pinching cursor and not a
pointing one.

Also it would be nice if there was an easy way to view all the
cursors. I'm thinking of creating a simple application with just
single window with a BMenuField to select the cursor which sets the
cursor for the app to what is selected. Feel free to implement that
yourself if you want and if I don't do it within the next few days.

Also with this change you've addressed this enhancement ticket:

http://dev.haiku-os.org/ticket/3420

I've given you ownership and marked it fixed.

-- 
Regards,
Ryan

Other related posts: