[haiku-commits] Re: r35603 - haiku/trunk/src/system/kernel/slab

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 24 Feb 2010 18:34:24 +0100

Ingo Weinhold <ingo_weinhold@xxxxxx> wrote:
> On 2010-02-24 at 16:08:52 [+0100], axeld@xxxxxxxxxxxxxxxx wrote:
> >  void
> >  dump_object_depot(object_depot* depot)
> >  {
> > -    kprintf("  full:  %p, count %lu\n", depot->full, depot-
> > >full_count);
> > -    kprintf("  empty: %p, count %lu\n", depot->empty, depot-
> > >empty_count);
> > +    kprintf("  full:     %p, count %lu\n", depot->full, depot-
> > >full_count);
> > +    kprintf("  empty:    %p, count %lu\n", depot->empty, 
> > depot->empty_count);
> > +    kprintf("  max full: %lu\n", depot->max_count);
> > +    kprintf("  capacity: %lu\n", depot->magazine_capacity);
> A general note: Please use the B_PRI*/B_SCN* macros in 
> *printf()/*scanf() 
> formats. Adjusting all the format string will be a major pain in the 
> back 
> when porting to a 64 bit architecture. No need to keep making the 
> task bigger.

Alright, will try to keep that in mind :-)

Bye,
   Axel.


Other related posts: