[haiku-commits] Re: r35598 - haiku/trunk/src/apps/terminal
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: haiku-commits@xxxxxxxxxxxxx
- Date: Wed, 24 Feb 2010 16:59:22 +0100
On 2010-02-24 at 15:11:48 [+0100], PulkoMandy <pulkomandy@xxxxxxxxx> wrote:
> > Modified: haiku/trunk/src/apps/terminal/TermWindow.cpp
> > ===================================================================
> > --- haiku/trunk/src/apps/terminal/TermWindow.cpp 2010-02-24 14:06:02
> > UTC
> > (rev 35597)
> > +++ haiku/trunk/src/apps/terminal/TermWindow.cpp 2010-02-24 14:06:40
> > UTC
> > (rev 35598)
> > @@ -818,6 +818,8 @@
> > SetSizeLimits(MIN_COLS * width - 1, MAX_COLS * width - 1,
> > minimumHeight + MIN_ROWS * height - 1,
> > minimumHeight + MAX_ROWS * height - 1);
> > + // TODO: The size limit computation is apparently broken,
> > since
> > + // the terminal can be resized smaller than
> > MIN_ROWS/MIN_COLS!
> > // If it's the first time we're called, setup the window
> > if (fTabView->CountTabs() == 1) {
>
> I think that's my fault : a long time ago I made a patch to add a 3-pixel
> wide border around the terminal text to have it look nicer. I think I just
> missed this when writing the patch...
I haven't checked how many pixels it is off, but in the vertical case it
could indeed be 6. Horizontally there must be another issue, though, since
the specified minimum is 10, but one can actually shrink the terminal to 7
character columns.
I guess the best solution would be to use layout management for the window.
CU, Ingo
Other related posts:
